fix(docs-next): External url paths in sidebar are truncated#2245
Merged
dancormier merged 6 commits intomainfrom Apr 24, 2026
Merged
fix(docs-next): External url paths in sidebar are truncated#2245dancormier merged 6 commits intomainfrom
dancormier merged 6 commits intomainfrom
Conversation
|
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The inner anchor's rel was keyed off subsection.externalUrl while its href is derived from item.externalUrl, so a nested external item would not get rel="external" and a subsection with externalUrl plus items would apply rel="external" to internal children. Also re-indent the inner block to match the 2-space style used elsewhere in the file and move href onto its own line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dancormier
previously approved these changes
Apr 24, 2026
Contributor
dancormier
left a comment
dancormier
left a comment
There was a problem hiding this comment.
Looking good @abovedave I pushed a commit with some minor formatting changes and a change to ensure the rel value syncs up with the href value on these items.
It's good to go! 🚀
eslint-disable-next-line only suppresses the line immediately after it. Moving href onto its own line put it two lines below the comment, so svelte/no-navigation-without-resolve fired again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dancormier
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently they are passed to
resolve()which removes the first char of the string and prefixes with the base url.